Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing record kind test #2366

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix failing record kind test #2366

merged 2 commits into from
Feb 2, 2024

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 1, 2024

No description provided.

@elliette elliette requested a review from nshahan February 1, 2024 23:09
nshahan
nshahan approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through all the details of class, type, kind, ref, etc with me!

@elliette elliette merged commit a67291d into dart-lang:master Feb 2, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

Assignees
No one assigned
Labels
changelog-not-required package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @nshahan