Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to the release script #2363

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Small fixes to the release script #2363

merged 2 commits into from
Jan 29, 2024

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jan 25, 2024 •
edited
Loading

  • Always use dependency overrides for the test_common package
  • Insert the "- Update dwds constraint to version" at the 3rd line of the CHANGELOG (before it would get added at the top of the CHANGELOG and I would have to manually move it)

nshahan
nshahan approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliette elliette merged commit 2539d54 into dart-lang:master Jan 29, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

@Markzipan Markzipan Awaiting requested review from Markzipan

@annagrin annagrin Awaiting requested review from annagrin

Assignees
No one assigned
Labels
changelog-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @nshahan