Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package:vm_service constraints to allow version 14.x #2307

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

derekxu16
Copy link
Member

No description provided.

@derekxu16 derekxu16 force-pushed the update-vm-service-constraint branch 3 times, most recently from 3c09c67 to fdf8645 Compare December 18, 2023 15:18
@derekxu16 derekxu16 force-pushed the update-vm-service-constraint branch from fdf8645 to f9fdb9b Compare December 18, 2023 15:22
@derekxu16 derekxu16 requested a review from elliette December 18, 2023 19:32
@derekxu16 derekxu16 marked this pull request as ready for review December 18, 2023 19:32
webdev/CHANGELOG.md Outdated Show resolved Hide resolved
webdev/pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two requests

@elliette
Copy link
Contributor

Thanks! I'm working on getting the CI checks passing. I will merge this once everything is passing.

Copy link

auto-submit bot commented Dec 20, 2023

auto label is removed for dart-lang/webdev/2307, due to - The status or check suite analyzer_and_format; linux; Dart dev; PKG: dwds; `dart format --output=none --set-exit-if-changed... has failed. Please fix the issues identified (or deflake) before re-applying this label.

@elliette elliette merged commit 3b2f67e into dart-lang:master Jan 2, 2024
46 checks passed
@@ -33,8 +33,8 @@ dependencies:
stack_trace: ^1.10.0
sse: ^4.1.2
uuid: ^3.0.6
vm_service: ^13.0.0
vm_service_interface: 1.0.0
vm_service: ^14.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this constraint can be loosened to >=13.0.0 <15.0.0 since the breaking changes in 14.0.0 aren't actually going to impact DWDS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do another release of dwds with the version constraint loosened?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this version of DWDS in the next stable release, I think so. We can't roll 14.0.0 through to Flutter yet since it'll break network profiling in DevTools until this SDK change lands.

@derekxu16 derekxu16 deleted the update-vm-service-constraint branch August 29, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants