-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package:vm_service constraints to allow version 14.x #2307
Update package:vm_service constraints to allow version 14.x #2307
Conversation
3c09c67
to
fdf8645
Compare
fdf8645
to
f9fdb9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two requests
Thanks! I'm working on getting the CI checks passing. I will merge this once everything is passing. |
auto label is removed for dart-lang/webdev/2307, due to - The status or check suite analyzer_and_format; linux; Dart dev; PKG: dwds; `dart format --output=none --set-exit-if-changed... has failed. Please fix the issues identified (or deflake) before re-applying this label. |
@@ -33,8 +33,8 @@ dependencies: | |||
stack_trace: ^1.10.0 | |||
sse: ^4.1.2 | |||
uuid: ^3.0.6 | |||
vm_service: ^13.0.0 | |||
vm_service_interface: 1.0.0 | |||
vm_service: ^14.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this constraint can be loosened to >=13.0.0 <15.0.0
since the breaking changes in 14.0.0 aren't actually going to impact DWDS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I do another release of dwds with the version constraint loosened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this version of DWDS in the next stable release, I think so. We can't roll 14.0.0 through to Flutter yet since it'll break network profiling in DevTools until this SDK change lands.
No description provided.