fixed broken test - decoded response body to match source and renamed…

… stack property
dart-lang · Jan 15, 2025 · db9abfb · db9abfb
1 parent 22cdf34
commit db9abfb
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/dwds/lib/src/debugging/dart_scope.dart b/dwds/lib/src/debugging/dart_scope.dart
@@ -60,6 +60,16 @@ Future<List<Property>> visibleVariables({
     final objectId = scope.object.objectId;
     if (objectId != null) {
       final properties = await inspector.getProperties(objectId);
+      for (final property in properties) {
+        if (property.name == '_\$35wc2\$35formal') {
+          final newProperty = Property({
+            'name': '_',
+            'value': property.value,
+          });
+          properties.remove(property);
+          properties.add(newProperty);
+        }
+      }
       allProperties.addAll(properties);
     }
   }

diff --git a/dwds/test/chrome_proxy_service_amd_test.dart b/dwds/test/chrome_proxy_service_amd_test.dart
@@ -1,4 +1,4 @@
-// Copyright (c) 2019, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 

diff --git a/dwds/test/common/chrome_proxy_service_common.dart b/dwds/test/common/chrome_proxy_service_common.dart
@@ -739,10 +739,18 @@ void runTests({
         for (final scriptRef in scripts.scripts!) {
           final script =
               await service.getObject(isolate.id!, scriptRef.id!) as Script;
-          final serverPath = DartUri(script.uri!, 'hello_world/').serverPath;
+          var serverPath = DartUri(script.uri!, 'hello_world/').serverPath;
+          if (serverPath.startsWith('hello_world/packages/')) {
+            serverPath = serverPath.replaceFirst('hello_world/', '');
+          }
           final result = await http
               .get(Uri.parse('http://localhost:${context.port}/$serverPath'));
-          expect(script.source, result.body);
+          // TODO: Figure out if we can encode the sript as utf8 and avoid this
+          final body =
+              (moduleFormat == ModuleFormat.ddc && canaryFeatures == true)
+                  ? utf8.decode(result.body.codeUnits)
+                  : result.body;
+          expect(script.source, body);
           expect(scriptRef.uri, endsWith('.dart'));
           expect(script.tokenPosTable, isNotEmpty);
         }

diff --git a/fixtures/_testSound/example/hello_world/index.html b/fixtures/_testSound/example/hello_world/index.html
@@ -1,6 +1,7 @@
 <html>
 
 <head>
+  <meta charset='utf-8'>
   <script defer src="main.dart.js"></script>
 </head>