replaced wildcard with timer

dart-lang · Jan 16, 2025 · d4ec13f · d4ec13f
1 parent aa38d3a
commit d4ec13f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 19 deletions.
diff --git a/dwds/test/common/chrome_proxy_service_common.dart b/dwds/test/common/chrome_proxy_service_common.dart
@@ -1542,24 +1542,20 @@ void runTests({
         expect(first.code!.name, 'printCount');
       });
 
-      test(
-        'stack has a variable',
-        () async {
-          final stack = await breakAt('callPrintCount');
-          expect(stack, isNotNull);
-          expect(stack.frames, hasLength(1));
-          final first = stack.frames!.first;
-          expect(first.kind, 'Regular');
-          expect(first.code!.kind, 'Dart');
-          expect(first.code!.name, '<closure>');
-          // TODO: Make this more precise once this case doesn't
-          // also include all the libraries.
-          expect(first.vars, hasLength(greaterThanOrEqualTo(1)));
-          final underscore = first.vars!.firstWhere((v) => v.name == '_');
-          expect(underscore, isNotNull);
-        },
-        skip: 'https://github.com/dart-lang/webdev/issues/2570',
-      );
+      test('stack has a variable', () async {
+        final stack = await breakAt('callPrintCount');
+        expect(stack, isNotNull);
+        expect(stack.frames, hasLength(1));
+        final first = stack.frames!.first;
+        expect(first.kind, 'Regular');
+        expect(first.code!.kind, 'Dart');
+        expect(first.code!.name, '<closure>');
+        // TODO: Make this more precise once this case doesn't
+        // also include all the libraries.
+        expect(first.vars, hasLength(greaterThanOrEqualTo(1)));
+        final underscore = first.vars!.firstWhere((v) => v.name == 'timer');
+        expect(underscore, isNotNull);
+      });
 
       test('collects async frames', () async {
         final stack = await breakAt('asyncCall');

diff --git a/fixtures/_testSound/example/hello_world/main.dart b/fixtures/_testSound/example/hello_world/main.dart
@@ -76,7 +76,7 @@ void main() async {
     scheduleMicrotask(() => throw Exception('UncaughtException'));
   };
 
-  Timer.periodic(const Duration(seconds: 1), (_) {
+  Timer.periodic(const Duration(seconds: 1), (timer) {
     printCount(); // Breakpoint: callPrintCount
   });