Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose EventStreamProvider from helpers, prepare 0.2.1-beta release #75

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Expose EventStreamProvider from helpers, prepare 0.2.1-beta release #75

merged 1 commit into from
Sep 19, 2023

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Sep 19, 2023 •
edited
Loading

No description provided.

@kevmoo kevmoo force-pushed the event_stream_provider branch from c77277c to 6eb3357 Compare September 19, 2023 21:46
@kevmoo kevmoo requested review from srujzs and sigmundch September 19, 2023 21:46
@kevmoo kevmoo changed the title event stream provider Expose EventStreamProvider from helpers, prepare 0.2.1-beta release Sep 19, 2023
@srujzs
Copy link
Contributor

srujzs commented Sep 19, 2023

I think this is fine to expose. Even if we exposed all the EventStreamProviders that dart:html exposes, we'd still be missing a few events that have been added since the last IDL roll e.g. beforexrselect.

@kevmoo kevmoo merged commit 819f8b4 into main Sep 19, 2023
@kevmoo kevmoo deleted the event_stream_provider branch September 19, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

@sigmundch sigmundch Awaiting requested review from sigmundch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @srujzs