Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for FileSystemEntityType.notFound #80

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

sortie
Copy link
Contributor

@sortie sortie commented Mar 6, 2020

The Dart breaking change dart-lang/sdk#40706 will change the timestamps on the notFound object from null to the epoch timestamp. This change updates package:watcher accordingly. The change is backwards compatible and forwards compatible.

This pull requests blocks the dart-lang/sdk#40706 breaking change which blocks the Dart SDK NNBD unfork. Please review and commit the change if you approve, and then please make a package:watcher release on pub. We'll then want the change to roll into G3 and Dart/Flutter.

The Dart breaking change <dart-lang/sdk#40706>
will change the timestamps on the notFound object from null to the epoch
timestamp.
@sortie sortie added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) high priority labels Mar 6, 2020
@sortie sortie requested a review from natebosch March 6, 2020 15:29
@natebosch natebosch merged commit 45634d9 into master Mar 6, 2020
@natebosch natebosch deleted the sortie-filesystemenentitytype-notfound branch March 6, 2020 16:53
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
The Dart breaking change <dart-lang/sdk#40706>
will change the timestamps on the notFound object from null to the epoch
timestamp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants