Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analysis across packages #1187

Merged
merged 2 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bazel_worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [3.1.0, dev]
sdk: [3.4, dev]
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
Expand Down
4 changes: 4 additions & 0 deletions pkgs/bazel_worker/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.1.3-wip

* Require Dart SDK `^3.4.0`.

## 1.1.2

* Require Dart SDK `^3.1.0`.
Expand Down
4 changes: 0 additions & 4 deletions pkgs/bazel_worker/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,3 @@ analyzer:
errors:
# For the generated file
lines_longer_than_80_chars: ignore

linter:
rules:
- package_api_docs
4 changes: 2 additions & 2 deletions pkgs/bazel_worker/e2e_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ name: e2e_test
publish_to: none

environment:
sdk: '>=2.19.0 <4.0.0'
sdk: ^3.4.0

dependencies:
bazel_worker:
path: ../

dev_dependencies:
cli_util: ^0.4.0
cli_util: ^0.4.2
dart_flutter_team_lints: ^1.0.0
path: ^1.8.0
test: ^1.16.0
1 change: 0 additions & 1 deletion pkgs/bazel_worker/e2e_test/test/e2e_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import 'package:path/path.dart' as p;
import 'package:test/test.dart';

void main() {
var sdkPath = getSdkPath();
var dart = p.join(sdkPath, 'bin', 'dart');
runE2eTestForWorker('sync worker',
() => Process.start(dart, [p.join('bin', 'sync_worker.dart')]));
Expand Down
4 changes: 2 additions & 2 deletions pkgs/bazel_worker/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: bazel_worker
version: 1.1.2
version: 1.1.3-wip
description: >-
Protocol and utilities to implement or invoke persistent bazel workers.
repository: https://github.com/dart-lang/tools/tree/main/pkgs/bazel_worker

environment:
sdk: ^3.1.0
sdk: ^3.4.0

dependencies:
async: ^2.5.0
Expand Down
1 change: 0 additions & 1 deletion pkgs/boolean_selector/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ linter:
rules:
- avoid_unused_constructor_parameters
- cancel_subscriptions
- package_api_docs
1 change: 0 additions & 1 deletion pkgs/coverage/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ linter:
- cancel_subscriptions
- comment_references
- literal_only_boolean_expressions
- package_api_docs
- prefer_final_locals
- sort_constructors_first
- sort_unnamed_constructors_first
Expand Down
1 change: 0 additions & 1 deletion pkgs/graphs/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_locals
Expand Down
1 change: 0 additions & 1 deletion pkgs/json_rpc_2/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ linter:
rules:
- avoid_unused_constructor_parameters
- cancel_subscriptions
- package_api_docs
1 change: 0 additions & 1 deletion pkgs/mime/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_locals
Expand Down
1 change: 0 additions & 1 deletion pkgs/oauth2/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ linter:
- literal_only_boolean_expressions
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- unnecessary_await_in_return
- use_string_buffers