Recompile host.dart #2448
Recompile host.dart #2448
Conversation
Recompile with the latest dart2js.
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
| _lazyFinal($, "_v8EvalLocation", "$get$_v8EvalLocation", () => A.RegExp_RegExp("^eval at (?:\\S.*?) \\((.*)\\)(?:, .*?:\\d+:\\d+)?$", false)); | ||
| _lazyFinal($, "_firefoxEvalLocation", "$get$_firefoxEvalLocation", () => A.RegExp_RegExp("(\\S+)@(\\S+) line (\\d+) >.* (Function|eval):\\d+:\\d+", false)); | ||
| _lazyFinal($, "_firefoxSafariFrame", "$get$_firefoxSafariFrame", () => A.RegExp_RegExp("^(?:([^@(/]*)(?:\\(.*\\))?((?:/[^/]*)*)(?:\\(.*\\))?@)?(.*?):(\\d*)(?::(\\d*))?$", false)); | ||
| _lazyFinal($, "_firefoxSafariJSFrame", "$get$_firefoxSafariJSFrame", () => A.RegExp_RegExp("^(?:([^@(/]*)(?:\\(.*\\))?((?:/[^/]*)*)(?:\\(.*\\))?@)?(.*?):(\\d*)(?::(\\d*))?$", false)); |
There was a problem hiding this comment.
This is the blocking line and regex.
|
https://github.com/dart-lang/test/security/code-scanning/149
As far as I can tell this regex is not changing, but other content on the same line as the regex is changing. Confusingly the error is reported with the old line number, but the regex doesn't change between the two copies. @devoncarew @kevmoo - do you know what caused this check to start happening when we previously had this regex checked in? Is it something we can turn off temporarily? @sigmundch - is this potentially inefficient regex a concern for the dart2js team? |
|
I'm not particularly concerned. This seems to come from https://github.com/dart-lang/tools/blob/ce3003493b86333e7652ee5bb62bc7913b2d11b7/pkgs/stack_trace/lib/src/frame.dart#L71 - this logic is used only to parse frame lines from stack traces in FF/Safari, which usually don't start with |
|
that's a HUGE drop in code size. Did we drop dart:html here? |
it does look like there is a big chunk of removed stuff that look like This does not yet migrate to the new interop though. Maybe something made treeshaking work better here? Nothing that is dropped strikes me as something we would be using. |
Recompile with the latest dart2js.