Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout doesn't work for package:webdev test #1203

Closed
grouma opened this issue Mar 20, 2020 · 2 comments
Closed

Timeout doesn't work for package:webdev test #1203

grouma opened this issue Mar 20, 2020 · 2 comments
Assignees

Comments

@grouma
Copy link
Member

grouma commented Mar 20, 2020

Remove the registerExtension call here:
https://github.com/dart-lang/webdev/blob/6dec3735b18ec19d1d3221a003167d98584538f5/example/web/main.dart#L13

Next run this test:
https://github.com/dart-lang/webdev/blob/6dec3735b18ec19d1d3221a003167d98584538f5/webdev/test/daemon/app_domain_test.dart#L61

This expectLater will now fail:
https://github.com/dart-lang/webdev/blob/6dec3735b18ec19d1d3221a003167d98584538f5/webdev/test/daemon/app_domain_test.dart#L69

However, the test never times out. The test runner hasn't completely stalled as it continually reports the elapsed time.

grouma added a commit to dart-lang/webdev that referenced this issue Mar 20, 2020
@natebosch
Copy link
Member

Broken by dart-lang/test_process#17

@natebosch
Copy link
Member

This is approximately working as intended. Closing this in favor of the feature request to add a configuration for the timeout that would do what you hoped for here.

#1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants