Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stop-points at backward branches (using stack overflow checks) #664

Closed
ghost opened this issue Dec 1, 2011 · 2 comments
Closed

Implement stop-points at backward branches (using stack overflow checks) #664

ghost opened this issue Dec 1, 2011 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@ghost
Copy link

ghost commented Dec 1, 2011

In order to stop a runaway isolate or for inserting debugging breakpoints we need to stop inside a loop. Simplest implementation is to always use stack overflow check at backward branches.
@iposva-google
Copy link
Contributor

Added Accepted label.

@ghost
Copy link
Author

ghost commented Mar 2, 2012

Implemented in r4889

Added Fixed label.

@ghost ghost added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Mar 2, 2012
@ghost ghost self-assigned this Mar 2, 2012
copybara-service bot pushed a commit that referenced this issue Jun 8, 2022
Roll Dart Protobuf Support from b149f801cf7a to 408f69b98b2d (9 revis…
258846f 
…ions)

https://dart.googlesource.com/protobuf/+log/b149f801cf7a..408f69b98b2d

2022-06-08 omersa@google.com Update documentation according to Effective Dart documentation guide (#664)
2022-06-02 omersa@google.com Move closures in proto3 deserializer to top-level (#668)
2022-06-02 omersa@google.com Refactor protobuf bench runners, update README: (#665)
2022-06-02 omersa@google.com Benchmarks: add proto3 ser/deser benchs, move common code to common.dart (#667)
2022-06-02 omersa@google.com Remove makeLongInt helper (#666)
2022-05-31 lorenvs@outlook.com Use `-O4` when compiling benchmarks. (#552)
2022-05-25 omersa@google.com Remove invalid check in `_FieldSet.writeFieldValue` (#660)
2022-05-20 devoncarew@gmail.com Refactor file locations, update READMEs (#657)
2022-05-19 omersa@google.com Remove trailing whitespace in protoc_plugin/README

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-protobuf-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: I0f1aa66ee6fe167f37443957234f4d0140828416
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247467
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iposva-google