TypeAnalyzer needs to expect DYNAMIC typed properties

[bwilkerson]

I ran into this using build 4808. The input to the analyzer is invalid, but we probably need to do something better than throwing an exception.

!ENTRY com.google.dart.tools.core 4 0 2012-03-01 09:55:31.849
!MESSAGE Internal error: unexpected kind DYNAMIC
!STACK 0
java.lang.AssertionError: Internal error: unexpected kind DYNAMIC
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.internalError(TypeAnalyzer.java:244)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitPropertyAccess(TypeAnalyzer.java:1397)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitPropertyAccess(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartPropertyAccess.accept(DartPropertyAccess.java:95)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeOf(TypeAnalyzer.java:725)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.nonVoidTypeOf(TypeAnalyzer.java:739)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.analyzeArgumentTypes(TypeAnalyzer.java:436)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitMethodInvocation(TypeAnalyzer.java:814)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitMethodInvocation(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartMethodInvocation.accept(DartMethodInvocation.java:77)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeOf(TypeAnalyzer.java:725)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitExprStmt(TypeAnalyzer.java:975)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitExprStmt(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartExprStmt.accept(DartExprStmt.java:36)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visit(TypeAnalyzer.java:1707)
    at com.google.dart.compiler.ast.DartBlock.visitChildren(DartBlock.java:44)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeAsVoid(TypeAnalyzer.java:783)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitBlock(TypeAnalyzer.java:779)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitBlock(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartBlock.accept(DartBlock.java:49)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeOf(TypeAnalyzer.java:725)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitFunction(TypeAnalyzer.java:1032)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitFunction(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartFunction.accept(DartFunction.java:66)
    at com.google.dart.compiler.ast.DartMethodDefinition.visitChildren(DartMethodDefinition.java:78)
    at com.google.dart.compiler.ast.DartMethodDefinition$DartMethodWithInitializersDefinition.visitChildren(DartMethodDefinition.java:114)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeAsVoid(TypeAnalyzer.java:783)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitMethodDefinition(TypeAnalyzer.java:1162)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitMethodDefinition(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartMethodDefinition.accept(DartMethodDefinition.java:83)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeOf(TypeAnalyzer.java:725)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitField(TypeAnalyzer.java:1740)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitField(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartField.accept(DartField.java:78)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visit(TypeAnalyzer.java:1707)
    at com.google.dart.compiler.ast.DartFieldDefinition.visitChildren(DartFieldDefinition.java:50)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitFieldDefinition(TypeAnalyzer.java:981)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitFieldDefinition(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartFieldDefinition.accept(DartFieldDefinition.java:55)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visit(TypeAnalyzer.java:1707)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitClass(TypeAnalyzer.java:857)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitClass(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartClass.accept(DartClass.java:206)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visit(TypeAnalyzer.java:1707)
    at com.google.dart.compiler.ast.DartUnit.visitChildren(DartUnit.java:97)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.typeAsVoid(TypeAnalyzer.java:783)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitUnit(TypeAnalyzer.java:1585)
    at com.google.dart.compiler.type.TypeAnalyzer$Analyzer.visitUnit(TypeAnalyzer.java:1)
    at com.google.dart.compiler.ast.DartUnit.accept(DartUnit.java:105)
    at com.google.dart.compiler.type.TypeAnalyzer.exec(TypeAnalyzer.java:173)
    at com.google.dart.compiler.DartCompiler.analyzeLibrary(DartCompiler.java:1113)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.secureAnalyzeLibrary(DartCompilerUtilities.java:783)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities$ResolverRunnable.run(DartCompilerUtilities.java:444)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities$CompilerRunner.runSafe(DartCompilerUtilities.java:103)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveLibrary(DartCompilerUtilities.java:694)
    at com.google.dart.tools.core.internal.index.impl.InMemoryIndex.indexBundledLibraries(InMemoryIndex.java:344)
    at com.google.dart.tools.core.internal.index.impl.InMemoryIndex.initializeIndex(InMemoryIndex.java:238)
    at com.google.dart.tools.core.search.NewSearchEngineTest.setUp(NewSearchEngineTest.java:78)
    at junit.framework.TestCase.runBare(TestCase.java:132)
    at junit.framework.TestResult$1.protect(TestResult.java:110)
    at junit.framework.TestResult.runProtected(TestResult.java:128)
    at junit.framework.TestResult.run(TestResult.java:113)
    at junit.framework.TestCase.run(TestCase.java:124)
    at junit.framework.TestSuite.runTest(TestSuite.java:243)
    at junit.framework.TestSuite.run(TestSuite.java:238)
    at junit.framework.TestSuite.runTest(TestSuite.java:243)
    at junit.framework.TestSuite.run(TestSuite.java:238)
    at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
    at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)
    at org.eclipse.pde.internal.junit.runtime.CoreTestApplication.run(CoreTestApplication.java:23)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
    at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

[bwilkerson]

this.clone(true).elements

// unit dart://htmlimpl/htmlimpl.dart/src/SVGElementWrappingImplementation.dart
class _SVGClassSet extends _CssClassSet {

  _SVGClassSet(element) : super(element);

  String _className() {
    return _element.className.baseVal;
  }

  void _write(Set s) {
    _element.className.baseVal = _formatSet(s);
  }
}

class SVGElementWrappingImplementation extends ElementWrappingImplementation implements SVGElement {

  SVGElementWrappingImplementation._wrap(ptr) : super._wrap(ptr){
  }

  factory SVGElementWrappingImplementation.tag(String tag) {
    return LevelDom.wrapSVGElement(dom.document.createElementNS("http://www.w3.org/2000/svg", tag));
  }

  factory SVGElementWrappingImplementation.svg(String svg) {
    Element parentTag;
    var match = _START_TAG_REGEXP.firstMatch(svg);
    if (match != null && match.group(1).toLowerCase() == "svg") {
      parentTag = new Element.tag("div");
    } else {
      parentTag = new SVGSVGElement();
    }
    parentTag.innerHTML = svg;
    if (parentTag.elements.length == 1) {
      return parentTag.nodes.removeLast();
    }
    throw new IllegalArgumentException("SVG had ${parentTag.elements.length} " + "top-level elements but 1 expected");
  }

  Set<String> get classes() {
    if (_cssClassSet === null) {
      _cssClassSet = new _SVGClassSet(_ptr);
    }
    return _cssClassSet;
  }

  String get id() {
    return _ptr.id;
  }

  void set id(String value) {
    _ptr.id = value;
  }

  SVGSVGElement get ownerSVGElement() {
    return LevelDom.wrapSVGSVGElement(_ptr.ownerSVGElement);
  }

  SVGElement get viewportElement() {
    return LevelDom.wrapSVGElement(_ptr.viewportElement);
  }

  String get xmlbase() {
    return _ptr.xmlbase;
  }

  void set xmlbase(String value) {
    _ptr.xmlbase = value;
  }

  ElementList get elements() {
    if (_elements == null) {
      _elements = new FilteredElementList(this);
    }
    return _elements;
  }

  void set elements(value) {
    var elements = this.elements;
    elements.clear();
    elements.addAll(value);
  }

  String get outerHTML() {
    var container = new Element.tag("div");
    container.elements.add(this.clone(true));
    return container.innerHTML;
  }

  String get innerHTML() {
    var container = new Element.tag("div");
    container.elements.addAll(this.clone(true).elements);
    return container.innerHTML;
  }

  void set innerHTML(String svg) {
    var container = new Element.tag("div");
    container.innerHTML = "<svg version="1.1">${svg}</svg>";
    this.elements = container.elements.first.elements;
  }

  SVGElement clone(bool deep) {
    return super.clone(deep);
  }
}

[scheglov]

https://chromiumcodereview.appspot.com/9569030

---

Added Started label.

[scheglov]

https://code.google.com/p/dart/source/detail?r=4833

---

Added Fixed label.

[scheglov]

Issue #2016 has been merged into this issue.