Skip to content

Commit

Permalink
[vm/gardening] Skip shared isolates test on reload bots.
Browse files Browse the repository at this point in the history
The tests are spawning child processes, that can be slow on reload bots.

BUG=#56277
TEST=ci

Change-Id: I71ebbfd81c80937fce2dd49b18ebcb16d1cc5538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377080
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
  • Loading branch information
aam authored and Commit Queue committed Jul 22, 2024
1 parent 525a637 commit e197106
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions runtime/tests/vm/dart/isolates/shared_primitives_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ void main(List<String> args) async {
]);
if (Platform.version.contains('(main)') ||
Platform.version.contains('(dev)')) {
if (result.exitCode != 0) {
print('stdout: ${result.stdout}');
print('stderr: ${result.stderr}');
}
Expect.equals(0, result.exitCode);
} else {
Expect.notEquals(0, result.exitCode);
Expand Down
4 changes: 4 additions & 0 deletions runtime/tests/vm/dart/isolates/shared_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ void main(List<String> args) async {
]);
if (Platform.version.contains('(main)') ||
Platform.version.contains('(dev)')) {
if (result.exitCode != 0) {
print('stdout: ${result.stdout}');
print('stderr: ${result.stderr}');
}
Expect.equals(0, result.exitCode);
} else {
Expect.notEquals(0, result.exitCode);
Expand Down
2 changes: 2 additions & 0 deletions runtime/tests/vm/vm.status
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ dart/thread_priority_windows_test: SkipByDesign
[ $hot_reload || $hot_reload_rollback ]
dart/appjit*: SkipByDesign # Cannot reload with URI pointing to app snapshot.
dart/disassemble_determinism_test: SkipSlow # Runs expensive fibonacci(32) computation in 2 subprocesses
dart/isolates/shared_primitives_test: SkipSlow # The test spawns children processes, which is too slow on reload bots
dart/isolates/shared_test: SkipSlow # The test spawns children processes, which is too slow on reload bots
dart/issue_31959_31960_test: SkipSlow
dart/minimal_kernel_test: SkipSlow # gen_kernel is too slow in hot reload testing mode
dart/print_flow_graph_determinism_test: SkipSlow
Expand Down

0 comments on commit e197106

Please sign in to comment.