Skip to content

Commit

Permalink
DDC: disallow ignore option on Stream cast failures
Browse files Browse the repository at this point in the history
See #27223

Change-Id: Ia23edc3700a8e0bb3d982be9b0bb36ad4522091d
Reviewed-on: https://dart-review.googlesource.com/56033
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
  • Loading branch information
vsmenon authored and commit-bot@chromium.org committed May 22, 2018
1 parent e191d4f commit c771e4d
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,7 @@ final _ignoreTypeFailure = JS('', '''(() => {
if (!!$isSubtype(type, $Iterable) && !!$isSubtype(actual, $Iterable) ||
!!$isSubtype(type, $Future) && !!$isSubtype(actual, $Future) ||
!!$isSubtype(type, $Map) && !!$isSubtype(actual, $Map) ||
!!$isSubtype(type, $Stream) && !!$isSubtype(actual, $Stream)) {
!!$isSubtype(type, $Map) && !!$isSubtype(actual, $Map)) {
console.warn('Ignoring cast fail from ' + $typeName(actual) +
' to ' + $typeName(type));
return true;
Expand Down

0 comments on commit c771e4d

Please sign in to comment.