Handle relative git-url-paths correctly when --directory #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Mar 16, 2021
jonasfj
reviewed
Mar 18, 2021
jonasfj
reviewed
Mar 18, 2021
643d105 to
6f0b483
Compare
sigurdm
commented
Mar 19, 2021
jonasfj
approved these changes
Mar 22, 2021
| @@ -90,9 +90,14 @@ class GlobalPackages { | |||
| // dependencies. Their executables shouldn't be cached, and there should | |||
| // be a mechanism for redoing dependency resolution if a path pubspec has | |||
| // changed (see also issue 20499). | |||
| PackageRef ref; | |||
| try { | |||
| ref = cache.git.source.parseRef(name, {'url': repo}, containingPath: '.'); | |||
There was a problem hiding this comment.
Technically, we're going to write the pubspec.yaml somewhere other than ., so the containingPath should be something like $PUB_CACHE/global_packages/<package>/, shouldn't it?
I'm not sure it matters here?
There was a problem hiding this comment.
We don't write it to disk (yet), so it should not matter...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.