Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit exit code 69 for TlsExceptions #1730

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Emit exit code 69 for TlsExceptions #1730

merged 2 commits into from
Oct 24, 2017

Conversation

nex3
Copy link
Member

@nex3 nex3 commented Oct 23, 2017

Closes #1729

@nex3 nex3 requested a review from munificent October 23, 2017 21:21
munificent
munificent approved these changes Oct 24, 2017
View reviewed changes
lib/src/source/hosted.dart Outdated
@@ -329,7 +329,7 @@ class BoundHostedSource extends CachedSource {
stackTrace);
}

if (error is io.SocketException) {
if (error is io.SocketException || error is io.TlsException) {
fail("Got socket error trying to find package $package at $url.", error,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a more specific error message, like "Got TLS error ..." if it's a TlsException.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nex3 nex3 merged commit edc6b22 into master Oct 24, 2017
@nex3 nex3 deleted the tls-exception-exit-code branch October 24, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munificent munificent munificent approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nex3 @munificent @googlebot