Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub should handle pub server errors gracefully #1556

Closed
whesse opened this issue Apr 4, 2017 · 6 comments
Closed

Pub should handle pub server errors gracefully #1556

whesse opened this issue Apr 4, 2017 · 6 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@whesse
Copy link
Contributor

whesse commented Apr 4, 2017

The pub server will sometimes return a 500 (internal error), if there is a temporary failure on the server.
pub get should handle these results, and retry the fetch of the object from the server. If it doesn't retry, then it should return with a distinctive error code that indicates temporary failure. Maybe this should happen for other network failures when running pub get as well.

This would make the testing of pub get less flaky, and allow us to test it on the buildbot.
This seems related to issue #1534 and pr #1552

@mkustermann

@whesse whesse added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Apr 4, 2017
@UnikZ
Copy link
Contributor

UnikZ commented Apr 5, 2017

I think, pub server should return 503 status code for temporary failures according to https://tools.ietf.org/html/rfc2616#section-10.5.4

@whesse
Copy link
Contributor Author

whesse commented Apr 5, 2017

@mkustermann

This was referenced Oct 27, 2017
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug high priority and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Oct 27, 2017
@jcollins-g
Copy link
Contributor

This is a frequent source of temporary breakage on dartdoc's travis and appveyor.

@jakemac53
Copy link
Contributor

+1 package:build gets flakes on Travis all the time due to this

@gspencergoog
Copy link
Contributor

Also, if we are doing retries, they should be using an appropriate exponential backoff, not just fixed timeouts. As we grow, this will become more and more important...

nex3 added a commit that referenced this issue Dec 12, 2017
nex3 added a commit that referenced this issue Dec 15, 2017
* Retry HTTP requests that are temporarily failing

Closes #1556
@kevmoo
Copy link
Member

kevmoo commented Dec 16, 2017

The pub site is having issues now – tried the pub client at 932e76e

...no retries on 502 😕

@kevmoo kevmoo reopened this Dec 16, 2017
kevmoo added a commit that referenced this issue Dec 16, 2017
kevmoo added a commit that referenced this issue Dec 16, 2017
kevmoo added a commit that referenced this issue Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants