-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pub should handle pub server errors gracefully #1556
Comments
I think, pub server should return 503 status code for temporary failures according to https://tools.ietf.org/html/rfc2616#section-10.5.4 |
This is a frequent source of temporary breakage on dartdoc's travis and appveyor. |
+1 package:build gets flakes on Travis all the time due to this |
Also, if we are doing retries, they should be using an appropriate exponential backoff, not just fixed timeouts. As we grow, this will become more and more important... |
* Retry HTTP requests that are temporarily failing Closes #1556
The pub site is having issues now – tried the pub client at 932e76e ...no retries on 502 😕 |
The pub server will sometimes return a 500 (internal error), if there is a temporary failure on the server.
pub get should handle these results, and retry the fetch of the object from the server. If it doesn't retry, then it should return with a distinctive error code that indicates temporary failure. Maybe this should happen for other network failures when running pub get as well.
This would make the testing of pub get less flaky, and allow us to test it on the buildbot.
This seems related to issue #1534 and pr #1552
@mkustermann
The text was updated successfully, but these errors were encountered: