-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModerationCase entity #7614
ModerationCase entity #7614
Conversation
isoos
commented
Apr 4, 2024
- New moderation and report processing flow #7535
- not in use yet, just the implementation of the specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is code generation being run for this file yet? (I don't see a .g file)...
/// - `moderation-upheld`, if this is an appeal (kind = appeal) of a notification | ||
/// where we applied content moderation, and we decided to uphold that decision. | ||
/// - `moderation-reverted`, if this is an appeal (kind = appeal) of a notification | ||
/// where we applied content moderation, and we decided to revert that decision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps document the null
case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we shouldn't allow null
? E.g. pending
could indicate the in-progress state, and it is also possible to filter for it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IF we want a pending thing, we should rename it status
.
For querying it's probably fine to have a pending
value.
This does not have any API-exposed use case, there is no need to generate JSON serialization. |
/// - `moderation-upheld`, if this is an appeal (kind = appeal) of a notification | ||
/// where we applied content moderation, and we decided to uphold that decision. | ||
/// - `moderation-reverted`, if this is an appeal (kind = appeal) of a notification | ||
/// where we applied content moderation, and we decided to revert that decision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IF we want a pending thing, we should rename it status
.
For querying it's probably fine to have a pending
value.
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Maybe it is better to reduce the possible values to |