Allow sdk packages #7609
Allow sdk packages #7609
Conversation
| final tarball = await packageArchiveBytes( | ||
| pubspecContent: generatePubspecYaml('xyz', '1.2.3') + | ||
| ' my_sdk_dep:\n' | ||
| ' sdk: dart\n'); |
There was a problem hiding this comment.
This will allow package to have any dependency as long as they have sdk: dart (or sdk:flutter)?
We should probably have a tool or test that checks allow-listing regularly and indicates which to remove. |
|
As far as SDK packages are concerned this will allow dependency on any SDK package. I think that's fine, you can pick one that doesn't exist, and then the package won't work for anyone. That's sad, but probably people will test their package first 🙈 We could make a list of allowed SDK-dependencies. But I'm not sure it's necessary. |
|
LGTM, will the other fix (to add |
That fix will allow you to publish |
Did you mean |
We were not able to deploy it yet. (needed to roll back) |
Fixing the issue where packages with SDK-dependencies can't be published.
CC @jakemac53 (I believe we'll have a workaround for
_macrosout today'ish; this will ship thursday or next week)Noticed some slow tests and ended up filing:
#7608