Use browser's history when displaying/hiding the infobox on mobile view. #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Jan 31, 2024
- Fixes Navigating back from metadata popup should go back to package-page #7428
- Unfortunately this increased the complexity of the view toggle a bit, but history API is not really friendly in this regard.
e89a134 to
e6cb953
Compare
jonasfj
reviewed
Mar 6, 2024
Comment on lines
+80
to
+81
| // only listen to state events after the first initialization | ||
| stateSubscription ??= window.onPopState.listen((event) async { |
There was a problem hiding this comment.
This won't work well, if you:
- Navigate to
pub.dev/packages/retry - Toggle the "details / meta-data" view
- Click the repository link (navigating to
github.com/...) - Click the back button.
- The "details / meta-data" view will not be active, leaving users disappointed.
Am I wrong? (I haven't tested the theory)
We could say that (5) is an acceptable downside.
We could also use pub.dev/packages/retry#details to toggle the "details / meta-data" view. Storing the state in document.location.hash.
We might be able to use the hashchange event then. Though it might be just as complicated.
An alternative is to create a separate page: pub.dev/packages/<package>/details that contains the sidebar. It'll be a bit sad, because it won't work when you resize the window.
There was a problem hiding this comment.
I've deployed the PR to staging, and it seems to me that clicking through 1-5 is working as expected, at least on Chrome.
jonasfj
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.