Fix /api/archives/ handler (#7599)

dart-lang · Mar 27, 2024 · 418931f · 418931f
1 parent 60583d9
commit 418931f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/lib/frontend/handlers/pubapi.dart b/app/lib/frontend/handlers/pubapi.dart
@@ -60,7 +60,7 @@ class PubApi {
   /// clients, so while this is deprecated we need to support it indefinitely.
   @EndPoint.get('/api/packages/<package>/versions/<version>/archive.tar.gz')
   @EndPoint.get('/packages/<package>/versions/<version>.tar.gz')
-  @EndPoint.get('/api/archives/<package>-<version>.tar.gz')
+  @EndPoint.get('/api/archives/<package|[^-/]+>-<version>.tar.gz')
   Future<Response> fetchPackage(
     Request request,
     String package,

diff --git a/app/lib/frontend/handlers/pubapi.g.dart b/app/lib/frontend/handlers/pubapi.g.dart
diff --git a/app/test/frontend/handlers/invalid_package_url_test.dart b/app/test/frontend/handlers/invalid_package_url_test.dart
@@ -31,7 +31,7 @@ void main() {
     expect(urls, contains('/packages/<package>/versions/<version>'));
     expect(urls, contains('/api/packages/<package>'));
     // this a naive assertion that fails, if new end-points are introduced!
-    expect(urls, hasLength(44), reason: 'check if new end-points was added');
+    expect(urls, hasLength(43), reason: 'check if new end-points was added');
   });
 
   testWithProfile(