Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

Pool.withResource() should take () -> FutureOr<T>. #7

Merged
merged 2 commits into from
May 17, 2017
Merged

Pool.withResource() should take () -> FutureOr<T>. #7

merged 2 commits into from
May 17, 2017

Conversation

nex3
Copy link
Member

@nex3 nex3 commented May 15, 2017

@nex3 nex3 requested a review from efortuna May 15, 2017 21:27
efortuna
efortuna approved these changes May 15, 2017
View reviewed changes
Copy link

@efortuna efortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! much nicer!

@nex3 nex3 merged commit 6b5e963 into master May 17, 2017
@nex3 nex3 deleted the with-resource-future-or branch May 17, 2017 03:44
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
@nex3
Pool.withResource() should take () -> FutureOr<T>. (dart-lang/pool#7)
c289d1c 
Closes dart-lang/pool#6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@efortuna efortuna efortuna approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withResource() when callback returns a future and strong mode errors
3 participants
@nex3 @efortuna @googlebot