Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add withCredentials to base methods #7

Merged
merged 2 commits into from
Apr 6, 2015

Conversation

johnryan-wf
Copy link
Contributor

This adds withCredentials as an optional parameter for BaseClient requests. When not using BrowserClient, this flag is ignored. Defaults to false.

@nex3 Please let me know if you would prefer a different approach

@johnryan-wf
Copy link
Contributor Author

this addresses #5 I think

@nex3
Copy link
Member

nex3 commented Apr 3, 2015

I don't want to add anything platform-specific to the shared Request class. Ultimately, my goal is to move http to a more shelf-like API with a context getter, which would work well for this, but that's a ways away. For now, it's probably best to put this property on BrowserClient.

@johnryan-wf johnryan-wf closed this Apr 5, 2015
@johnryan-wf johnryan-wf reopened this Apr 5, 2015
@johnryan-wf
Copy link
Contributor Author

@nex3 I agree that's a cleaner solution. Done.

@nex3 nex3 merged commit 9d76e5e into dart-lang:master Apr 6, 2015
@TyrusLabs TyrusLabs mentioned this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants