add transformer tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab52744 to
0943c55
Compare
| @@ -14,7 +14,11 @@ import '../asset/writer.dart'; | |||
| import '../builder/builder.dart'; | |||
| import '../builder/build_step_impl.dart'; | |||
|
|
|||
| abstract class BuilderTransformer implements Transformer, DeclaringTransformer { | |||
| /// A [Transformer] which runs multiple [Builder]s. Extend this class and define | |||
There was a problem hiding this comment.
uber nit: line break after the first sentence here, per Effective Dart
0943c55 to
977579c
Compare
| @@ -14,7 +14,12 @@ import '../asset/writer.dart'; | |||
| import '../builder/builder.dart'; | |||
| import '../builder/build_step_impl.dart'; | |||
|
|
|||
| abstract class BuilderTransformer implements Transformer, DeclaringTransformer { | |||
| /// A [Transformer] which runs multiple [Builder]s. | |||
| /// Extend this class and define the [builders] getter to create a [Transformer] | |||
There was a problem hiding this comment.
I still think we should be explicit about our (lack of) ordering guarantees here, maybe just as simple as "there are no guarantees about the order in which [Builder]s will be run."
|
LGTM! |
977579c to
6f59037
Compare
This was referenced Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2