Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

add the angularapp template #140

Closed
wants to merge 1 commit into from
Closed

add the angularapp template #140

wants to merge 1 commit into from

Conversation

devoncarew
Copy link
Contributor

Add the newly created angularpp template into stagehand (thanks @laco0416 !).

I do see an issue on my machine:

Loading angular transformers... (1.6s)
Error on line 15, column 3 of pubspec.yaml: Error loading transformer: Illegal argument(s): sdkDirectory must be provided.
- angular
  ^^^^^^^

Which, I was not able to solve by setting the sdk_dir setting on the angular transformer. Do not know why. I was able to get the app running by removing the angular transformer and changing the di method over to a dynamic one. The compiled output for the app ballooned up a bit (~3MB).

In any case, @sethladd, let me know what you think.

@sethladd
Copy link
Contributor

sethladd commented Nov 1, 2014

I'll have to give it a try, but if we can't fix it, then we'll have to remove this template. No one wants a 3MB JavaScript file. :)

@lacolaco
Copy link

lacolaco commented Nov 1, 2014

Hmm... On my machine, the angularapp generator (I pulled just now) works completely.
DartVM: 1.7.2 linux_x64
Pub : 1.7.2

@devoncarew
Copy link
Contributor Author

Apparently, this shows up when the dart vm in your path is a symlink to the vm. In this case, the code_transformers package, referenced by di, referenced by angular, can't properly locate the dart sdk. Not sure what it needs in there. This doesn't occur if the sdk proper is in your path (not a symlink to the VM). People who install the sdk via brew will run into this issue.

@a14n
Copy link
Contributor

a14n commented Nov 3, 2014

See http://dartbug.com/21225

@lacolaco
Copy link

lacolaco commented Nov 3, 2014

This is a same issue at angular.dart repo dart-archive/angular.dart#1270 (comment)

Solution:

...
transformers:
- angular:
    dart_sdk: "/path/to/sdk"

@sethladd
Copy link
Contributor

sethladd commented Nov 4, 2014

Thanks for the workaround. I'd love for this to work out of the box, so I imagine we'll have to fix code_transformers package.

@devoncarew
Copy link
Contributor Author

To tie this up: we'll hold off on this PR until there's a fix to code_transformers.

@lacolaco
Copy link

code_transformers is upgraded to 0.2.3.2+. It says

Added logic to discover the location of the dart SDK when the dart binary is a symlink.

Thanks!

But we maybe have to wait for upgrading angular. And AngularDart's master branch has not committed in over 20 days... 😵

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants