Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Add image/heic mime type #58

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

aliasgarlabs
Copy link
Contributor

Adding heic extension with mime type image/heic.

@google-cla google-cla bot added the cla: no label Nov 15, 2021
@aliasgarlabs
Copy link
Contributor Author

I signed it!

@kevmoo kevmoo requested a review from natebosch November 15, 2022 20:55
@kevmoo
Copy link
Contributor

kevmoo commented Nov 15, 2022

should have a changelog entry and a test!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 15, 2022
@kevmoo
Copy link
Contributor

kevmoo commented Nov 15, 2022

@natebosch – should we do a "dot" release 1.1 – since we are adding features?

@natebosch
Copy link
Contributor

@natebosch – should we do a "dot" release 1.1 – since we are adding features?

Since 1.0 we've done patch releases for adding mime types. I think you could make a good argument either way, but my inclination is to stick with that pattern.

@natebosch natebosch merged commit dcf97ee into dart-archive:master Nov 15, 2022
mosuem pushed a commit to dart-lang/tools that referenced this pull request Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants