Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Enforce package:pedantic lints #41

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Enforce package:pedantic lints #41

merged 3 commits into from
Jan 27, 2020

Conversation

konstantinullrich
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@konstantinullrich
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

///
/// [type] is used for the error message. It should begin with an indefinite
/// article.
dynamic _getTyped(String type, bool Function(dynamic) test) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't move this function around – makes viewing the diff more difficult

# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete everything out of this file except this line

Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits...

@konstantinullrich
Copy link
Contributor Author

Greetings from Germany

@kevmoo i implemented the changes you requested

@kevmoo kevmoo merged commit 2e6c9a7 into dart-archive:master Jan 27, 2020
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants