This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Apply --scope-output filters after getSourceReport
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--scope-output filters after getSourceReport--scope-output filters after getSourceReport
bkonyi
reviewed
Jul 30, 2024
lib/src/collect.dart
Outdated
| if (isEmpty) return true; | ||
| final scriptUri = Uri.parse(scriptUriString); | ||
| if (scriptUri.scheme != 'package') return false; | ||
| final scope = scriptUri.path.split('/').first; |
There was a problem hiding this comment.
Nit: would final scope = scriptUri.pathSegments.first achieve the same thing?
| extension _ScopedOutput on Set<String> { | ||
| bool includesScript(String? scriptUriString) { | ||
| if (scriptUriString == null) return false; | ||
| if (isEmpty) return true; |
There was a problem hiding this comment.
Shouldn't this return false if the set is empty? If not, can you leave a comment explaining why we're considering an empty set to include all scripts?
There was a problem hiding this comment.
Added a comment
test/collect_coverage_mock_test.dart
Outdated
| when(service.getSourceReport('isolate', ['Coverage'], | ||
| forceCompile: true, | ||
| reportLines: true, | ||
| libraryFilters: ['package:foo/'])) |
There was a problem hiding this comment.
Ubernit: consider adding trailing commas for formatting.
bkonyi
approved these changes
Jul 31, 2024
| extension _ScopedOutput on Set<String> { | ||
| bool includesScript(String? scriptUriString) { | ||
| if (scriptUriString == null) return false; | ||
| if (isEmpty) return true; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--scope-outputfilters are passed togetSourceReport.libraryFilters, but there are cases where the report can contain ranges that bypass the filter. This happens when the range has a different library than their enclosing function/class (eg mixins).To fix this we just need to re-apply the filters to the reported ranges. It's still important to pass the filters to
getSourceReport, because these are pretty rare edge cases and the filtering is still a useful optimisation to reduce the size of the report.Fixes dart-lang/tools#530