Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Add extension method for easy creation #11

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Add extension method for easy creation #11

merged 5 commits into from
Nov 13, 2019

Conversation

mit-mit
Copy link
Contributor

@mit-mit mit-mit commented Nov 12, 2019

No description provided.

@mit-mit mit-mit requested a review from lrhn November 12, 2019 19:31
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/extensions.dart Show resolved Hide resolved
lib/src/extensions.dart Outdated Show resolved Hide resolved
lib/src/extensions.dart Outdated Show resolved Hide resolved
@mit-mit
Copy link
Contributor Author

mit-mit commented Nov 13, 2019

Thanks, updated, PTAL @lrhn

Copy link
Contributor

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if fixing the example.

CHANGELOG.md Outdated
of the string:

```dart
print('The first character is: ' + myString.characters.take(1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be .first instead of .take(1). The latter returns a Characters, not a String, and Characters cannot be added to a string.
(Would work if you use string interpolation instead of + because the Characters toString returns the string).

Copy link
Contributor

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! LGTM. Ship it!

@mit-mit mit-mit merged commit 1714979 into master Nov 13, 2019
@mit-mit mit-mit deleted the extension branch November 13, 2019 12:49
mit-mit added a commit to mit-mit/characters that referenced this pull request Jul 26, 2021
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants