CI: drop 3.6 & ubuntu switch #870
Merged
+2
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the Github Actions infrastructure is progressively phasing in a newer base image of Ubuntu: https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/ * that means that we are somewhat randomly going to see images that lack Python `3.6` from the build cache sometimes per: actions/setup-python#355 (comment) * instead of pinning to an old version of Ubuntu in GHA for 3.6 support, let's just drop 3.6 from the testing matrix per: darshan-hpc#510 (comment) (it has been EOL for 1 year) * there's also no reason to retain the special Python `3.10` handling where we use Ubuntu `22.04` for that case, for two reasons: 1) `22.04` is being rolled out as the new default anyway 2) darshan-hpcgh-851 with the Python garbage collection issues in `3.10` was resolved by using contexts, so special treatment not justified anymore
shanedsnyder
approved these changes
Dec 9, 2022
|
To fully remove on from 3.6, there are still some other tasks, correct? Off the top of my head, I guess pyproject.toml needs to be updated so cibuildwheel doesn't build wheels for it, but probably other things, too, I'm guessing. Are those out of scope here? Or is it worth ripping the bandaid off? |
|
I was just going to remove the CI support to start, I don't really care if we continue here though, but you'll end up with randomly failing CI for awhile if you wait |
|
Maybe I'll just merge this in, and can start up a more general PR shortly, just to avoid any distractions on any other PRs in the mean time. |
tylerjereddy
added a commit
to tylerjereddy/darshan-logs
that referenced
this pull request
Dec 16, 2022
* for the same reasons as in the main repo: darshan-hpc/darshan#870 * `3.6` causing issues in PRs here now like in: darshan-hpcgh-46
This was referenced Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Github Actions infrastructure is progressively phasing in a newer base image of Ubuntu:
https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/
that means that we are somewhat randomly going to see images that lack Python
3.6from the build cache sometimes per:Python 3.6 fails to setup actions/setup-python#355 (comment)
instead of pinning to an old version of Ubuntu in GHA for 3.6 support, let's just drop 3.6 from the testing matrix per:
MAINT: when Python 3.6 is dropped #510 (comment) (it has been EOL for 1 year)
there's also no reason to retain the special Python
3.10handling where we use Ubuntu22.04for that case, for two reasons:22.04is being rolled out as the new default anyway3.10was resolved by using contexts, so special treatment not justified anymore