Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure every plugins can build #109

Merged
merged 8 commits into from
Aug 21, 2021
Merged

Ensure every plugins can build #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed3f9ef
Cleanup deps
darkweak Aug 18, 2021
684016f
Add Github action for caddy plugin
darkweak Aug 18, 2021
44e2ddd
fix badger max version to ensure caddy can build
darkweak Aug 18, 2021
942489c
Add tyk check
darkweak Aug 18, 2021
02a934d
Add Træfik check
darkweak Aug 18, 2021
023219c
Fix lint & update CI lint
darkweak Aug 21, 2021
d071f73
Enhance .golangci
darkweak Aug 21, 2021
26f128f
Bump caddy deps
darkweak Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ go 1.15

require (
github.com/buraksezer/olric v0.3.11
github.com/dgraph-io/badger/v3 v3.2103.1
github.com/dgraph-io/ristretto v0.1.0
github.com/dgraph-io/badger/v3 v3.2011.1
github.com/dgraph-io/ristretto v0.0.4-0.20210122082011-bb5d392ed82d
Comment on lines +7 to +8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading Badger v3 prevents Caddy from building? That isn't due to the prior commits build failure was it? That was about an RC version of Badger v2 AFAIK.

At least when I used xcaddy I used --with to override for latest v2 release and it build successfully avoiding the same build failure error I linked which was experienced in my bug report.

There was some nice improvements in the newer releases of Badger v3, if there was another issue that you experienced with building Caddy can you reference it and any related Github issue to track?

github.com/fsnotify/fsnotify v1.4.9
github.com/go-chi/stampede v0.4.5
github.com/golang-jwt/jwt v3.2.2+incompatible
Expand Down
Loading