-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure every plugins can build #109
Merged
darkweak
merged 8 commits into
master
from
fix/plugins/caddy/ensure-caddy-module-can-be-built
Aug 21, 2021
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ed3f9ef
Cleanup deps
darkweak 684016f
Add Github action for caddy plugin
darkweak 44e2ddd
fix badger max version to ensure caddy can build
darkweak 942489c
Add tyk check
darkweak 02a934d
Add Træfik check
darkweak 023219c
Fix lint & update CI lint
darkweak d071f73
Enhance .golangci
darkweak 26f128f
Bump caddy deps
darkweak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Build and validate Souin as plugins | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| build-caddy-validator: | ||
| name: Checkout code | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Install Go | ||
| uses: actions/setup-go@v2 | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| - name: Install xcaddy | ||
| run: | | ||
| sudo apt install -y debian-keyring debian-archive-keyring apt-transport-https | ||
| curl -1sLf 'https://dl.cloudsmith.io/public/caddy/xcaddy/gpg.key' | sudo apt-key add - | ||
| curl -1sLf 'https://dl.cloudsmith.io/public/caddy/xcaddy/debian.deb.txt' | sudo tee /etc/apt/sources.list.d/caddy-xcaddy.list | ||
| sudo apt update | ||
| sudo apt install xcaddy | ||
| - name: Build Souin as caddy module | ||
| run: cd plugins/caddy && xcaddy build --with github.com/darkweak/souin/plugins/caddy=./ --with github.com/darkweak/souin@latest=../.. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgrading Badger v3 prevents Caddy from building? That isn't due to the prior commits build failure was it? That was about an RC version of Badger v2 AFAIK.
At least when I used xcaddy I used
--withto override for latest v2 release and it build successfully avoiding the same build failure error I linked which was experienced in my bug report.There was some nice improvements in the newer releases of Badger v3, if there was another issue that you experienced with building Caddy can you reference it and any related Github issue to track?