Fix default engine display problem for fresh profile

Fix brave#3254 auditor: @bbondy
darkdh · Aug 20, 2016 · f82a848 · bbondy · Aug 20, 2016 · f82a848
1 parent 7b5f6d6
commit f82a848
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/js/about/preferences.js b/js/about/preferences.js
@@ -365,11 +365,12 @@ class GeneralTab extends ImmutableComponent {
 
 class SearchSelectEntry extends ImmutableComponent {
   shouldComponentUpdate (nextProps, nextState) {
-    return this.props.settings.get(settings.DEFAULT_SEARCH_ENGINE) !== nextProps.settings.get(settings.DEFAULT_SEARCH_ENGINE)
+    return getSetting(settings.DEFAULT_SEARCH_ENGINE, this.props.settings) !==
+      getSetting(settings.DEFAULT_SEARCH_ENGINE, nextProps.settings)
   }
   render () {
     return <div>
-    {this.props.settings.get(settings.DEFAULT_SEARCH_ENGINE) === this.props.name
+    {getSetting(settings.DEFAULT_SEARCH_ENGINE, this.props.settings) === this.props.name
       ? <span className='fa fa-check-square' id='searchSelectIcon' /> : null}
     </div>
   }