Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for demo #1

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Fix for demo #1

merged 1 commit into from
Dec 3, 2019

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Dec 3, 2019

The issue we were facing was reported here jestjs/jest#5064
This is a jest issue. PowerShell will interpreted all outputs in stderr as failure. Thus, I change that to use bash.

Before merging this PR please do the following steps:

  1. Acquire the HelloWorldSlots function app stage slot SCM credentials and placed it in GitHub repository secret SCM_CREDENTIALS.
  2. In the HelloWorldSlots function app stage slot app settings, add WEBSITE_RUN_FROM_PACKAGE = 1 manually, (since SCM credentials do not have privilege to change app settings)

There's a limitation in slot deployment using slot-name with SCM for WebApp and FunctionApp GitHub Actions. The related issues are here, Azure/webapps-deploy#6, Azure/functions-action#25

@dariagrigoriudemo dariagrigoriudemo merged commit fdea592 into dariagrigoriudemo:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants