-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Spring Boot Cloud Config #1230
base: master
Are you sure you want to change the base?
Conversation
25b3e33
to
2b4022b
Compare
…dcoded prefix(dapr#1225) create a public static final value PROPERTY_PREFIX in DaprClientProperties change the prefix value in the ConfigurationProperties to DaprClientProperties.PROPERTY_PREFIX Dapr Cloud Config rely on that. Signed-off-by: lony2003 <zhangke200377@outlook.com>
…of Spring Cloud Config(dapr#1225) Originally from https://github.com/fangkehou-team/dapr-spring, this library created a backend of SpringCloudConfig just like SpringCloudVault. The original library only uses secret store as config store api is not stable at that time. As the configuration api is stable now, the config loader using that api would be implemented later. Signed-off-by: lony2003 <zhangke200377@outlook.com>
@lony2003 first of all, thanks so so much for contributing back with this. This is highly appreciated.. I will start adding comments in the PR with small details that we need to fix and questions about how this would work. It will be great if you can add as part of this PR an example on the |
...ain/java/io/dapr/spring/boot/cloudconfig/autoconfigure/DaprCloudConfigAutoConfiguration.java
Outdated
Show resolved
Hide resolved
import io.dapr.spring.boot.autoconfigure.client.DaprClientProperties; | ||
import io.dapr.spring.boot.autoconfigure.client.DaprConnectionDetails; | ||
|
||
class CloudConfigPropertiesDaprConnectionDetails implements DaprConnectionDetails { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lony2003 do we need to duplicate the DaprConnectionDetails, why are these different for the normal DaprConnectionDetails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No difference, just because the PropertyDaprConnectionDetails is protected and can't be used in another package.
...onfig/src/main/java/io/dapr/spring/boot/cloudconfig/config/DaprCloudConfigClientManager.java
Outdated
Show resolved
Hide resolved
...udconfig/src/main/java/io/dapr/spring/boot/cloudconfig/config/DaprCloudConfigProperties.java
Show resolved
Hide resolved
Thanks. the code is not completed currently, I created this pull request is for the problems in issue #1225 , I think we need a schema for cloud config url, and have some other things to be discussed😊😊😊 |
Signed-off-by: lony2003 <zhangke200377@outlook.com>
Signed-off-by: lony2003 <zhangke200377@outlook.com>
Cloud Config Import SchemasSecret Store Componenturl structure
paramters
demomultiValued = false:store content(file secret store as example){
"dapr.spring.demo-config-secret.singlevalue": "testvalue",
"multivalue-properties": "dapr.spring.demo-config-secret.multivalue.v1=spring\ndapr.spring.demo-config-secret.multivalue.v2=dapr",
"multivalue-yaml": "dapr:\n spring:\n demo-config-secret:\n multivalue:\n v3=cloud"
} valid demo url
multiValued = true, nestedSeparator = ".":store content(file secret store as example){
"value1": {
"dapr": {
"spring": {
"demo-config-secret": {
"multivalue": {
"v4": "config"
}
}
}
}
}
} will be read as {
"value1": {
"dapr.spring.demo-config-secret.multivalue.v4": "config"
}
} valid demo url
Configuration Componenturl structure
paramters
Demostore content(table as example)
valid demo url
|
…porter Implemented the configuration importer using dapr client configuration api also done a style check Signed-off-by: lony2003 <zhangke200377@outlook.com>
Signed-off-by: lony2003 <zhangke200377@outlook.com>
Description
A new library that implement a backend of Spring Cloud Config.
Originally from https://github.com/fangkehou-team/dapr-spring, this library created a backend of SpringCloudConfig just like SpringCloudVault.
The original library only uses secret store as config store api is not stable at that time.
As the configuration api is stable now, the config loader using that api would be implemented later.
Not all things have done, will be updated later, please leave this pull request open.
Issue reference
this PR will close: #1225
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: