fix(examples): update deprecated flag #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Nguyen <hey@mike.ee>
yaron2
approved these changes
Feb 14, 2025
|
Looks like the format of the argument changed? |
mikeee
commented
Feb 18, 2025
15f636b to
39e0017
Compare
I think the issue is upstream with the CLI accepting the argument as an int rather than a string. Will PR a fix. |
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Mike Nguyen <hey@mike.ee>
d335d8e to
416e80d
Compare
|
Upstream - dapr/cli#1490 |
Signed-off-by: Mike Nguyen <hey@mike.ee>
yaron2
added a commit
that referenced
this pull request
Feb 28, 2025
* Adding the name of the failing activity. For more detail (#678) Signed-off-by: arturo <jarturotrenard@gmail.com> * add deadlettertopic support to non-streaming subscriptions (#685) * add deadlettertopic support to non-streaming subscriptions Signed-off-by: yaron2 <schneider.yaron@live.com> * fix tests Signed-off-by: yaron2 <schneider.yaron@live.com> --------- Signed-off-by: yaron2 <schneider.yaron@live.com> * Pick #674 and bump to rc13 (#686) * Bump gover, tag, x/deps and dapr (#674) * release: bump to rc2 Signed-off-by: mikeee <hey@mike.ee> * chore: upgrade x/net and x/crypto Signed-off-by: mikeee <hey@mike.ee> * release: bump go to 1.23.5 and dapr to rc5 Signed-off-by: mikeee <hey@mike.ee> * ci: bump validation workflow versions Signed-off-by: mikeee <hey@mike.ee> * bump cli and runtime to latest rc Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: bump dapr to rc7 and dt-go to head Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: bump to rc8 Signed-off-by: mikeee <hey@mike.ee> * chore(release): bump to latest Signed-off-by: mikeee <hey@mike.ee> --------- Signed-off-by: mikeee <hey@mike.ee> Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: bump cli and runtime vers Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: bump to rc13 Signed-off-by: Mike Nguyen <hey@mike.ee> --------- Signed-off-by: mikeee <hey@mike.ee> Signed-off-by: Mike Nguyen <hey@mike.ee> * feat: reconnect stream when grpc code is unknown / unavailable (#692) * feat: reconnect stream when grpc code is unknown / unavailable Signed-off-by: Eileen Yu <eileenylj@gmail.com> * log error for closing stream Signed-off-by: Eileen Yu <eileenylj@gmail.com> --------- Signed-off-by: Eileen Yu <eileenylj@gmail.com> * ci: include pre-release label for RCs (#675) * ci: include pre-release label for RCs Signed-off-by: Mike Nguyen <hey@mike.ee> * ci: enumerate if statements Signed-off-by: Mike Nguyen <hey@mike.ee> --------- Signed-off-by: Mike Nguyen <hey@mike.ee> * docs(sdk): add basic workflow example (#691) * docs(sdk): add basic workflow example Signed-off-by: Mike Nguyen <hey@mike.ee> * docs: fix indentations Signed-off-by: Mike Nguyen <hey@mike.ee> --------- Signed-off-by: Mike Nguyen <hey@mike.ee> * update conversation api field name (#695) Signed-off-by: yaron2 <schneider.yaron@live.com> * fix(examples): update deprecated flag (#689) * fix(examples): update deprecated flag Signed-off-by: Mike Nguyen <hey@mike.ee> * ci: test cli PR Signed-off-by: Mike Nguyen <hey@mike.ee> * test(service): bump body size to 41Mi Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: bump cli to rc6 and runtime to rc16 Signed-off-by: Mike Nguyen <hey@mike.ee> --------- Signed-off-by: Mike Nguyen <hey@mike.ee> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> * release: v1.12.0 version (#700) Signed-off-by: Mike Nguyen <hey@mike.ee> * ci: revert rc tests (#701) Signed-off-by: Mike Nguyen <hey@mike.ee> --------- Signed-off-by: arturo <jarturotrenard@gmail.com> Signed-off-by: yaron2 <schneider.yaron@live.com> Signed-off-by: mikeee <hey@mike.ee> Signed-off-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Eileen Yu <eileenylj@gmail.com> Co-authored-by: Arturo Trenard <jarturotrenard@gmail.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Eileen Yu <48944635+Eileen-Yu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: