Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add endpoint field to aws sns binding #4189

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Eileen-Yu
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Make docs in align with the aws.sns metadata schema defined here: dapr/components-contrib#3433

Issue reference

@Eileen-Yu Eileen-Yu requested review from a team as code owners June 5, 2024 21:04
@Eileen-Yu Eileen-Yu changed the base branch from v1.13 to v1.14 June 5, 2024 21:05
Signed-off-by: Eileen Yu <eileenylj@gmail.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit c6e8f1e into dapr:v1.14 Jun 8, 2024
6 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @Eileen-Yu Enjoy your Dapr docs badge!

Copy link

holopin-bot bot commented Jun 17, 2024

Congratulations @Eileen-Yu, you just earned a badge! Here it is: https://holopin.io/claim/clxj39se402840cl7li18ssjc

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants