Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go limitations #4052

Merged
merged 7 commits into from
Mar 4, 2024
Merged

add go limitations #4052

merged 7 commits into from
Mar 4, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Feb 29, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add limitations as requested for the go-sdk workflow implementation

Issue reference

This PR will close: ##4040

Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee changed the title add go limitions add go limitations Feb 29, 2024
Signed-off-by: Mike Nguyen <hey@mike.ee>
msfussell
msfussell previously approved these changes Feb 29, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms added this to the 1.13 milestone Feb 29, 2024
@hhunter-ms hhunter-ms linked an issue Feb 29, 2024 that may be closed by this pull request
@msfussell msfussell dismissed their stale review February 29, 2024 22:01

Still in draft

@mikeee mikeee marked this pull request as ready for review March 1, 2024 13:22
@mikeee mikeee requested review from a team as code owners March 1, 2024 13:22
@mikeee mikeee requested a review from hhunter-ms March 1, 2024 21:47
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 19d807b into dapr:v1.13 Mar 4, 2024
4 checks passed
@mikeee mikeee deleted the wf-docs branch March 4, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workflow] Go SDK limitations
3 participants