Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update s3 bindings links #3782

Merged
merged 4 commits into from
Oct 17, 2023
Merged

update s3 bindings links #3782

merged 4 commits into from
Oct 17, 2023

Conversation

martbln
Copy link
Contributor

@martbln martbln commented Oct 4, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Fixed the links to S3 bindings operations in the documentation.

Issue reference

Signed-off-by: Ilia Stepin <stepinilya@gmail.com>
@martbln martbln requested review from a team as code owners October 4, 2023 09:48
@msfussell
Copy link
Member

@martbln - Thanks for this PR. I suggest that we make this consistent, by renaming all the heading to files and referencing objects. So I suggest changing the following and also changing the headers to match. Could you take a pass on the whole topic? Thanks

@msfussell
Copy link
Member

@martbln - Would love to get this change in tomorrow. Can you look at my feedback?

Signed-off-by: Ilia Stepin <stepinilya@gmail.com>
@msfussell
Copy link
Member

@martbln - Pinging again?

@yaron2
Copy link
Member

yaron2 commented Oct 17, 2023

@martbln - Pinging again?

Changes addressed. Thanks for your contribution @martbln

@yaron2 yaron2 added this to the 1.13 milestone Oct 17, 2023
@yaron2 yaron2 merged commit f0ef4b9 into dapr:v1.11 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants