Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYO certs - Changed to support v3 certs with SAN #1510

Merged
merged 2 commits into from
May 24, 2021
Merged

BYO certs - Changed to support v3 certs with SAN #1510

merged 2 commits into from
May 24, 2021

Conversation

benc-uk
Copy link
Contributor

@benc-uk benc-uk commented May 24, 2021

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Since Go v1.15.2 it is expected that certs have a SAN field (see this issue), the instructions in the current mTLS docs for bringing your own cert do not generate certs in this format or with this field. This results in errors and warnings when Sentry starts and also in the injected sidecars

This PR provides instructions and commands to generate v3 certs with the correct SAN extension field

The instructions now use the openssl command rather than step as it's not easy to generate v3 certs with step.

Issue reference

Fixes #1498

@benc-uk benc-uk requested a review from a team as a code owner May 24, 2021 08:45
@AaronCrawfis AaronCrawfis merged commit b801b56 into dapr:v1.1 May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trust bundle should use leaf certificates
2 participants