BYO certs - Changed to support v3 certs with SAN #1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Since Go v1.15.2 it is expected that certs have a SAN field (see this issue), the instructions in the current mTLS docs for bringing your own cert do not generate certs in this format or with this field. This results in errors and warnings when Sentry starts and also in the injected sidecars
This PR provides instructions and commands to generate v3 certs with the correct SAN extension field
The instructions now use the
openssl
command rather thanstep
as it's not easy to generate v3 certs with step.Issue reference
Fixes #1498