Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding e2e test for cert renewal with given private key pem file #931

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

pravinpushkar
Copy link
Contributor

Signed-off-by: Pravin Pushkar ppushkar@microsoft.com

Description

  1. Parse provided pem encoded file before passing to x509.ParseECPrivateKey
  2. e2e tests added for renewing cert with given pem encoded private key file.
  3. Added an example-root.key file added in testdata

Issue reference

Related to issue #892

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar requested review from a team as code owners March 25, 2022 11:19
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #931 (d9afe88) into master (a134860) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   20.49%   20.46%   -0.04%     
==========================================
  Files          32       32              
  Lines        1888     1891       +3     
==========================================
  Hits          387      387              
- Misses       1447     1450       +3     
  Partials       54       54              
Impacted Files Coverage Δ
pkg/kubernetes/renew_certificate.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a134860...d9afe88. Read the comment docs.

@mukundansundar
Copy link
Collaborator

@yaron2 please review ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants