Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added api-log-level flag to log api calls #903

Merged
merged 18 commits into from
Mar 29, 2022
Merged

Added api-log-level flag to log api calls #903

merged 18 commits into from
Mar 29, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Mar 1, 2022

Description

Added api-log-level flag to give display the API call logs. It can be debug/info level.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: dapr/dapr#4119

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@amulyavarote amulyavarote requested review from a team as code owners March 1, 2022 22:32
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #903 (1371745) into master (6262b93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   21.01%   21.01%           
=======================================
  Files          32       32           
  Lines        1899     1899           
=======================================
  Hits          399      399           
  Misses       1446     1446           
  Partials       54       54           
Impacted Files Coverage Δ
pkg/standalone/run.go 59.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6262b93...1371745. Read the comment docs.

@mukundansundar
Copy link
Collaborator

mukundansundar commented Mar 2, 2022

@amulyavarote once dapr/dapr#4288 is merged and an RC is created, we can update the version of RC in CLI and use that here ... till then the E2E will fail here. Since CLI works with already released or release candidate versions of daprd available in GitHub (testing dapr init)and not directly building from dapr/dapr codebase as supported by SDKs.

amulyavarote and others added 17 commits March 28, 2022 14:56
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
@mukundansundar
Copy link
Collaborator

Please add E2E tests exercising the api log level flag ... in tests/e2e/standalone ...

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@mukundansundar mukundansundar mentioned this pull request Mar 29, 2022
72 tasks
@mukundansundar mukundansundar merged commit db56a25 into dapr:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Dapr API calls
4 participants