Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds native binary support for Darwin Arm64 (e.g. M1 Mac) #826

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Adds native binary support for Darwin Arm64 (e.g. M1 Mac) #826

merged 2 commits into from
Nov 10, 2021

Conversation

berndverst
Copy link
Member

Description

Adds native binary support for Darwin Arm64 (e.g. M1 Mac)

@berndverst berndverst requested review from a team as code owners November 10, 2021 17:42
@berndverst
Copy link
Member Author

This install script change works:

./install/install.sh
Your system is darwin_arm64
Installing Dapr CLI...

Getting the latest Dapr CLI...
Installing v1.4.0 Dapr CLI...
Downloading https://github.com/dapr/cli/releases/download/v1.4.0/dapr_darwin_arm64.tar.gz

(That of course fails because this artifact doesn't exist, but it will start working with a later 1.5.0 release candidate and the 1.5.0 release)

pkedy
pkedy previously approved these changes Nov 10, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #826 (671467b) into release-1.5 (55e18e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.5     #826   +/-   ##
============================================
  Coverage        21.82%   21.82%           
============================================
  Files               29       29           
  Lines             1535     1535           
============================================
  Hits               335      335           
  Misses            1159     1159           
  Partials            41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e18e9...671467b. Read the comment docs.

@berndverst
Copy link
Member Author

After this change behavior is as before where Darwin Arm64 binary does not exist:

./install.sh
The darwin_arm64 arch has no native binary for this version of Dapr, however you can use the amd64 version so long as you have rosetta installed
Use 'softwareupdate --install-rosetta' to install rosetta if you don't already have it
Installing Dapr CLI...

Getting the latest Dapr CLI...
Installing v1.4.0 Dapr CLI...
Downloading https://github.com/dapr/cli/releases/download/v1.4.0/dapr_darwin_amd64.tar.gz ...

wcs1only
wcs1only approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@wcs1only wcs1only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaron2 yaron2 merged commit 78db31a into dapr:release-1.5 Nov 10, 2021
berndverst added a commit to berndverst/cli that referenced this pull request Nov 10, 2021
@berndverst
Adds native binary support for Darwin Arm64 (e.g. M1 Mac) (dapr#826)
d2f2a9e 
* Add Darwin ARM64 binaries

* Update install script for Darwin Arm64
berndverst added a commit that referenced this pull request Nov 10, 2021
@berndverst
Install script update for Darwin ARM 64 (M1 Mac etc) support (#827)
1c5e1b3 
* Adds native binary support for Darwin Arm64 (e.g. M1 Mac) (#826)

* Add Darwin ARM64 binaries

* Update install script for Darwin Arm64

* Fix install script for M1 mac
anhldbk pushed a commit to anhldbk/dapr-cli that referenced this pull request Dec 22, 2021
@berndverst @anhldbk
Install script update for Darwin ARM 64 (M1 Mac etc) support (dapr#827)
7693f33 
* Adds native binary support for Darwin Arm64 (e.g. M1 Mac) (dapr#826)

* Add Darwin ARM64 binaries

* Update install script for Darwin Arm64

* Fix install script for M1 mac

Signed-off-by: Andy Le <anhldbk@gmail.com>
anhldbk pushed a commit to anhldbk/dapr-cli that referenced this pull request Dec 22, 2021
@berndverst @anhldbk
Install script update for Darwin ARM 64 (M1 Mac etc) support (dapr#827)
9ba6542 
* Adds native binary support for Darwin Arm64 (e.g. M1 Mac) (dapr#826)

* Add Darwin ARM64 binaries

* Update install script for Darwin Arm64

* Fix install script for M1 mac

Signed-off-by: Andy Le <anhldbk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcs1only wcs1only wcs1only approved these changes

@pkedy pkedy pkedy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berndverst @pkedy @wcs1only @yaron2