Fix daprsystem configuration retrieval when renewing certificates #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue found when similar resource were installed in k8s that use the name "configurations". In this case the knative's "configurations.serving.knative.dev/v1" was the last in the list and the command returned the error `Error from server (NotFound): configurations.serving.knative.dev "daprsystem" not found` Signed-off-by: Anton Troshin <anton@diagrid.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #1486 +/- ##
===============================================
Coverage ? 21.34%
===============================================
Files ? 44
Lines ? 5149
Branches ? 0
===============================================
Hits ? 1099
Misses ? 3966
Partials ? 84 ☔ View full report in Codecov by Sentry. |
yaron2
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue found when similar resource were installed in k8s that use the name "configurations". In this case the knative's "configurations.serving.knative.dev/v1" was the last in the list and the command returned the error
Error from server (NotFound): configurations.serving.knative.dev "daprsystem" not foundIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1485
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: