Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E for Run template #1170

Merged
merged 24 commits into from
Jan 24, 2023
Merged

Add E2E for Run template #1170

merged 24 commits into from
Jan 24, 2023

Conversation

mukundansundar
Copy link
Collaborator

@mukundansundar mukundansundar commented Jan 19, 2023

Description

Add E2E for run template.
Adds two go apps to be used in template testing.
The go apps use service invocation via dapr.
Linux slim run https://github.com/dapr/cli/actions/runs/3969444351/jobs/6803946473#step:9:793
Linux complete run https://github.com/dapr/cli/actions/runs/3969444351/jobs/6803946666#step:9:851

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1143

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1170 (39fad57) into master (14c04f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   26.12%   26.12%           
=======================================
  Files          38       38           
  Lines        2584     2584           
=======================================
  Hits          675      675           
  Misses       1843     1843           
  Partials       66       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@mukundansundar mukundansundar changed the title [WIP] Add E2E for Run template Add E2E for Run template Jan 20, 2023
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@mukundansundar mukundansundar marked this pull request as ready for review January 20, 2023 16:28
@mukundansundar mukundansundar requested review from a team as code owners January 20, 2023 16:28
# E2E Tests for Self-Hosted Template exec #
################################################################################
.PHONY: test-e2e-sh-template
test-e2e-sh-template: test-deps
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added this for easier e2e run locally.

Comment on lines +1 to +2
//go:build e2e && !template
// +build e2e,!template
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes in all the files are for allowing template PRs alone be able to run locally.
In CI all PRs are run since only e2e tag is passed.

Comment on lines +1 to +2
//go:build e2e || template
// +build e2e template
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will run if either e2e or template tag is passed. Locally using one of the make commands only template need to be passed. In CI, e2e is the tag that is passed

Copy link
Contributor

@pravinpushkar pravinpushkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
I will address the last two comments in my next PR.
adding E2E for dapr run -f <folder> and few nits.

@yaron2 yaron2 merged commit 17dbe5b into dapr:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capability to run multiple apps from a given run configuration file
3 participants