-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E for Run template #1170
Add E2E for Run template #1170
Conversation
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 26.12% 26.12%
=======================================
Files 38 38
Lines 2584 2584
=======================================
Hits 675 675
Misses 1843 1843
Partials 66 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
204a036
to
92eefc3
Compare
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
4e31347
to
c582380
Compare
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
c582380
to
8e6db41
Compare
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
# E2E Tests for Self-Hosted Template exec # | ||
################################################################################ | ||
.PHONY: test-e2e-sh-template | ||
test-e2e-sh-template: test-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added this for easier e2e run locally.
//go:build e2e && !template | ||
// +build e2e,!template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes in all the files are for allowing template PRs alone be able to run locally.
In CI all PRs are run since only e2e tag is passed.
//go:build e2e || template | ||
// +build e2e template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will run if either e2e or template tag is passed. Locally using one of the make commands only template need to be passed. In CI, e2e is the tag that is passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
I will address the last two comments in my next PR.
adding E2E for dapr run -f <folder>
and few nits.
Description
Add E2E for run template.
Adds two go apps to be used in template testing.
The go apps use service invocation via dapr.
Linux slim run https://github.com/dapr/cli/actions/runs/3969444351/jobs/6803946473#step:9:793
Linux complete run https://github.com/dapr/cli/actions/runs/3969444351/jobs/6803946666#step:9:851
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1143
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: