set default fields via struct default tag #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 30.06% 30.67% +0.61%
==========================================
Files 36 36
Lines 2458 2474 +16
==========================================
+ Hits 739 759 +20
+ Misses 1627 1624 -3
+ Partials 92 91 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shubham1172
suggested changes
Jan 10, 2023
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
shubham1172
reviewed
Jan 10, 2023
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
shubham1172
previously approved these changes
Jan 11, 2023
|
@pravinpushkar app-protocol defaults to http as well. |
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
mukundansundar
approved these changes
Jan 12, 2023
shubham1172
approved these changes
Jan 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pravin Pushkar ppushkar@microsoft.com
Description
Setting defaults values in the struct tag along with the run flags.