MSI Installer for CLI #1065
MSI Installer for CLI #1065
Conversation
Signed-off-by: shivamkm07 <shivamkm07@gmail.com>
Signed-off-by: shivamkm07 <shivamkm07@gmail.com>
|
NOTE: MSI ProductVersion is incompatible with semver. It only supports major.minor.build format, i.e. no pre-releases or build metadata. Also it has additional constraints like maximum value of major and minor fields is 255 and build field is 65535. So for msi installer, we can't have versions like "1.9.0-rc.1". Instead msi does allow a fourth numeric field in version, which is although ignored, but still legally allowed, like 1.9.0.1. So for rc releases, msi would be versioned the same. In summary: For edge builds, it would be tagged as '0.0.0.0' |
Signed-off-by: shivam <shivamkm07@gmail.com>
9ba2a16 to
5f1d0f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 29.20% 29.20%
=======================================
Files 35 35
Lines 2359 2359
=======================================
Hits 689 689
Misses 1594 1594
Partials 76 76 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@shivamkm07 Also update the README.md section for this ? |
Signed-off-by: shivam <shivamkm07@gmail.com>
Signed-off-by: shivam <shivamkm07@gmail.com>
There was a problem hiding this comment.
@shivamkm07 have the workflow changes been tested? If so please link it here
Yes: https://github.com/shivamkm07/cli/actions/runs/3051046246 The published msi file: https://github.com/shivamkm07/cli/releases/download/vedge/dapr.msi |
Signed-off-by: shivam <shivamkm07@gmail.com>
| @@ -29,3 +29,8 @@ test_output.json | |||
|
|
|||
| # Go Workspaces (introduced in Go 1.18+) | |||
| go.work | |||
|
|
|||
| #Wix files | |||
There was a problem hiding this comment.
| #Wix files | |
| # Wix files |
| @@ -0,0 +1,416 @@ | |||
| {\rtf1\adeflang1025\ansi\ansicpg1252\uc1\adeff31507\deff0\stshfdbch31506\stshfloch31506\stshfhich31506\stshfbi31507\deflang16393\deflangfe16393\themelang16393\themelangfe0\themelangcs0{\fonttbl{\f2\fbidi \fmodern\fcharset0\fprq1{\*\panose 02070309020205020404}Courier New;}{\f34\fbidi \froman\fcharset0\fprq2{\*\panose 02040503050406030204}Cambria Math;} | |||
There was a problem hiding this comment.
Curious to know, how did you generate this RTF file? Is the themedata at the bottom required?
Description
This adds Support for MSI Installer in CLI.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1064 _
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: