Require -k flag for annotate command #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joni Collinge <jonathancollinge@live.com>
Codecov Report
@@ Coverage Diff @@
## release-1.8 #1016 +/- ##
============================================
Coverage 28.46% 28.46%
============================================
Files 35 35
Lines 2312 2312
============================================
Hits 658 658
Misses 1579 1579
Partials 75 75 Continue to review full report at Codecov.
|
7 tasks
|
@jjcollinge Can you make the release-1.8 branch as the target branch for this PR? |
mukundansundar
approved these changes
Jul 5, 2022
hueifeng
pushed a commit
to hueifeng/cli
that referenced
this pull request
Jul 14, 2022
Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: hueifeng <695979933@qq.com>
hueifeng
pushed a commit
to hueifeng/cli
that referenced
this pull request
Jul 18, 2022
Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: hueifeng <695979933@qq.com>
hueifeng
pushed a commit
to hueifeng/cli
that referenced
this pull request
Jul 29, 2022
Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: hueifeng <695979933@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joni Collinge jonathancollinge@live.com
Description
Require the -k flag to target Kubernetes for the
dapr annotatecommand to make it consistent with other commands.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: