Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline char at end of dapr version output #1014

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

mukundansundar
Copy link
Collaborator

Description

Add newline char at end of dapr version cmd output

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1013

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar mukundansundar changed the base branch from master to release-1.8 June 28, 2022 06:46
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1014 (b066215) into release-1.8 (23e8b8b) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.8    #1014   +/-   ##
============================================
  Coverage        28.46%   28.46%           
============================================
  Files               35       35           
  Lines             2312     2312           
============================================
  Hits               658      658           
  Misses            1579     1579           
  Partials            75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e8b8b...b066215. Read the comment docs.

@mukundansundar mukundansundar modified the milestone: v1.8 Jun 28, 2022
@mukundansundar mukundansundar marked this pull request as ready for review June 28, 2022 07:24
@mukundansundar mukundansundar requested review from a team as code owners June 28, 2022 07:24
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@pravinpushkar
Copy link
Contributor

@mukundansundar Here is the output -

~/go_projects/src/github.com/dapr/cli on add-newline-char *21 !1 ?1 ❯ dist/linux_amd64/release/dapr version
CLI version: edge
Runtime version: 1.7.4
~/go_projects/src/github.com/dapr/cli on add-newline-char *21 ?1 ❯ dist/linux_amd64/release/dapr --version
CLI version: edge
Runtime version: 1.7.4%

@mukundansundar mukundansundar changed the title Add newline char at end of dapr version cmd output Add newline char at end of dapr version output Jun 28, 2022
@mukundansundar
Copy link
Collaborator Author

@mukundansundar Here is the output -

~/go_projects/src/github.com/dapr/cli on add-newline-char *21 !1 ?1 ❯ dist/linux_amd64/release/dapr version CLI version: edge Runtime version: 1.7.4 ~/go_projects/src/github.com/dapr/cli on add-newline-char *21 ?1 ❯ dist/linux_amd64/release/dapr --version CLI version: edge Runtime version: 1.7.4%

Fixed

pravinpushkar
pravinpushkar previously approved these changes Jun 28, 2022
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@yaron2 yaron2 merged commit f58c920 into dapr:release-1.8 Jun 28, 2022
@mukundansundar mukundansundar deleted the add-newline-char branch June 28, 2022 15:56
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 14, 2022
* add newline character at end of output of dapr version cmd

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* add newline char to dapr --version flag

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* refactor version template string

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: hueifeng <695979933@qq.com>
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 18, 2022
* add newline character at end of output of dapr version cmd

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* add newline char to dapr --version flag

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* refactor version template string

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: hueifeng <695979933@qq.com>
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 29, 2022
* add newline character at end of output of dapr version cmd

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* add newline char to dapr --version flag

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* refactor version template string

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: hueifeng <695979933@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A % sign is added at the end of dapr version command output
3 participants