-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newline char at end of dapr version output #1014
Conversation
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
17277f9
to
43e1ec6
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.8 #1014 +/- ##
============================================
Coverage 28.46% 28.46%
============================================
Files 35 35
Lines 2312 2312
============================================
Hits 658 658
Misses 1579 1579
Partials 75 75 Continue to review full report at Codecov.
|
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@mukundansundar Here is the output - ~/go_projects/src/github.com/dapr/cli on add-newline-char *21 !1 ?1 ❯ dist/linux_amd64/release/dapr version |
Fixed |
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
* add newline character at end of output of dapr version cmd Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * add newline char to dapr --version flag Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * refactor version template string Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: hueifeng <695979933@qq.com>
* add newline character at end of output of dapr version cmd Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * add newline char to dapr --version flag Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * refactor version template string Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: hueifeng <695979933@qq.com>
* add newline character at end of output of dapr version cmd Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * add newline char to dapr --version flag Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * refactor version template string Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: hueifeng <695979933@qq.com>
Description
Add newline char at end of dapr version cmd output
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1013
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: