Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing airgap init #1008

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fixing airgap init #1008

merged 1 commit into from
Jun 22, 2022

Conversation

shivamkm07
Copy link
Contributor

Description

Fixes airgap init in standalone mode, where some unnecessary config/component files were being created, causing dapr run to fail afterwards.

Issue reference

Please reference the issue this PR will close: #970

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@shivamkm07 shivamkm07 requested review from a team as code owners June 22, 2022 05:37
Signed-off-by: shivam <shivamkm07@gmail.com>
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1008 (a1bd7ea) into master (a7c748d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   28.46%   28.46%           
=======================================
  Files          35       35           
  Lines        2312     2312           
=======================================
  Hits          658      658           
  Misses       1579     1579           
  Partials       75       75           
Impacted Files Coverage Δ
pkg/standalone/standalone.go 4.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c748d...a1bd7ea. Read the comment docs.

@mukundansundar mukundansundar merged commit b126450 into dapr:master Jun 22, 2022
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 14, 2022
Signed-off-by: shivam <shivamkm07@gmail.com>
Signed-off-by: hueifeng <695979933@qq.com>
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 18, 2022
Signed-off-by: shivam <shivamkm07@gmail.com>
Signed-off-by: hueifeng <695979933@qq.com>
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 29, 2022
Signed-off-by: shivam <shivamkm07@gmail.com>
Signed-off-by: hueifeng <695979933@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dapr run fails after airgap dapr init
2 participants